.. | .. |
---|
1073 | 1073 | |
---|
1074 | 1074 | /* Assign public information to the rpmsg_device */ |
---|
1075 | 1075 | rpdev = &qsdev->rpdev; |
---|
1076 | | - strncpy(rpdev->id.name, channel->name, RPMSG_NAME_SIZE); |
---|
| 1076 | + strscpy_pad(rpdev->id.name, channel->name, RPMSG_NAME_SIZE); |
---|
1077 | 1077 | rpdev->src = RPMSG_ADDR_ANY; |
---|
1078 | 1078 | rpdev->dst = RPMSG_ADDR_ANY; |
---|
1079 | 1079 | |
---|
.. | .. |
---|
1304 | 1304 | |
---|
1305 | 1305 | spin_unlock_irqrestore(&edge->channels_lock, flags); |
---|
1306 | 1306 | |
---|
1307 | | - strncpy(chinfo.name, channel->name, sizeof(chinfo.name)); |
---|
| 1307 | + strscpy_pad(chinfo.name, channel->name, sizeof(chinfo.name)); |
---|
1308 | 1308 | chinfo.src = RPMSG_ADDR_ANY; |
---|
1309 | 1309 | chinfo.dst = RPMSG_ADDR_ANY; |
---|
1310 | 1310 | rpmsg_unregister_device(&edge->dev, &chinfo); |
---|
.. | .. |
---|
1364 | 1364 | } |
---|
1365 | 1365 | |
---|
1366 | 1366 | edge->ipc_regmap = syscon_node_to_regmap(syscon_np); |
---|
| 1367 | + of_node_put(syscon_np); |
---|
1367 | 1368 | if (IS_ERR(edge->ipc_regmap)) { |
---|
1368 | 1369 | ret = PTR_ERR(edge->ipc_regmap); |
---|
1369 | 1370 | goto put_node; |
---|
.. | .. |
---|
1388 | 1389 | edge->name = node->name; |
---|
1389 | 1390 | |
---|
1390 | 1391 | irq = irq_of_parse_and_map(node, 0); |
---|
1391 | | - if (irq < 0) { |
---|
| 1392 | + if (!irq) { |
---|
1392 | 1393 | dev_err(dev, "required smd interrupt missing\n"); |
---|
1393 | | - ret = irq; |
---|
| 1394 | + ret = -EINVAL; |
---|
1394 | 1395 | goto put_node; |
---|
1395 | 1396 | } |
---|
1396 | 1397 | |
---|
.. | .. |
---|
1469 | 1470 | edge->dev.release = qcom_smd_edge_release; |
---|
1470 | 1471 | edge->dev.of_node = node; |
---|
1471 | 1472 | edge->dev.groups = qcom_smd_edge_groups; |
---|
1472 | | - dev_set_name(&edge->dev, "%s:%s", dev_name(parent), node->name); |
---|
| 1473 | + dev_set_name(&edge->dev, "%s:%pOFn", dev_name(parent), node); |
---|
1473 | 1474 | ret = device_register(&edge->dev); |
---|
1474 | 1475 | if (ret) { |
---|
1475 | 1476 | pr_err("failed to register smd edge\n"); |
---|