| .. | .. |
|---|
| 7 | 7 | * This driver supports the Broadcom V3D 3.3 and 4.1 OpenGL ES GPUs. |
|---|
| 8 | 8 | * For V3D 2.x support, see the VC4 driver. |
|---|
| 9 | 9 | * |
|---|
| 10 | | - * Currently only single-core rendering using the binner and renderer |
|---|
| 11 | | - * is supported. The TFU (texture formatting unit) and V3D 4.x's CSD |
|---|
| 12 | | - * (compute shader dispatch) are not yet supported. |
|---|
| 10 | + * The V3D GPU includes a tiled render (composed of a bin and render |
|---|
| 11 | + * pipelines), the TFU (texture formatting unit), and the CSD (compute |
|---|
| 12 | + * shader dispatch). |
|---|
| 13 | 13 | */ |
|---|
| 14 | 14 | |
|---|
| 15 | 15 | #include <linux/clk.h> |
|---|
| 16 | 16 | #include <linux/device.h> |
|---|
| 17 | +#include <linux/dma-mapping.h> |
|---|
| 17 | 18 | #include <linux/io.h> |
|---|
| 18 | 19 | #include <linux/module.h> |
|---|
| 19 | 20 | #include <linux/of_platform.h> |
|---|
| 20 | 21 | #include <linux/platform_device.h> |
|---|
| 21 | 22 | #include <linux/pm_runtime.h> |
|---|
| 23 | +#include <linux/reset.h> |
|---|
| 24 | + |
|---|
| 25 | +#include <drm/drm_drv.h> |
|---|
| 22 | 26 | #include <drm/drm_fb_cma_helper.h> |
|---|
| 23 | 27 | #include <drm/drm_fb_helper.h> |
|---|
| 28 | +#include <drm/drm_managed.h> |
|---|
| 29 | +#include <uapi/drm/v3d_drm.h> |
|---|
| 24 | 30 | |
|---|
| 25 | | -#include "uapi/drm/v3d_drm.h" |
|---|
| 26 | 31 | #include "v3d_drv.h" |
|---|
| 27 | 32 | #include "v3d_regs.h" |
|---|
| 28 | 33 | |
|---|
| .. | .. |
|---|
| 100 | 105 | if (args->value != 0) |
|---|
| 101 | 106 | return -EINVAL; |
|---|
| 102 | 107 | |
|---|
| 103 | | - ret = pm_runtime_get_sync(v3d->dev); |
|---|
| 108 | + ret = pm_runtime_get_sync(v3d->drm.dev); |
|---|
| 109 | + if (ret < 0) |
|---|
| 110 | + return ret; |
|---|
| 104 | 111 | if (args->param >= DRM_V3D_PARAM_V3D_CORE0_IDENT0 && |
|---|
| 105 | 112 | args->param <= DRM_V3D_PARAM_V3D_CORE0_IDENT2) { |
|---|
| 106 | 113 | args->value = V3D_CORE_READ(0, offset); |
|---|
| 107 | 114 | } else { |
|---|
| 108 | 115 | args->value = V3D_READ(offset); |
|---|
| 109 | 116 | } |
|---|
| 110 | | - pm_runtime_mark_last_busy(v3d->dev); |
|---|
| 111 | | - pm_runtime_put_autosuspend(v3d->dev); |
|---|
| 117 | + pm_runtime_mark_last_busy(v3d->drm.dev); |
|---|
| 118 | + pm_runtime_put_autosuspend(v3d->drm.dev); |
|---|
| 112 | 119 | return 0; |
|---|
| 113 | 120 | } |
|---|
| 114 | 121 | |
|---|
| 115 | | - /* Any params that aren't just register reads would go here. */ |
|---|
| 116 | 122 | |
|---|
| 117 | | - DRM_DEBUG("Unknown parameter %d\n", args->param); |
|---|
| 118 | | - return -EINVAL; |
|---|
| 123 | + switch (args->param) { |
|---|
| 124 | + case DRM_V3D_PARAM_SUPPORTS_TFU: |
|---|
| 125 | + args->value = 1; |
|---|
| 126 | + return 0; |
|---|
| 127 | + case DRM_V3D_PARAM_SUPPORTS_CSD: |
|---|
| 128 | + args->value = v3d_has_csd(v3d); |
|---|
| 129 | + return 0; |
|---|
| 130 | + case DRM_V3D_PARAM_SUPPORTS_CACHE_FLUSH: |
|---|
| 131 | + args->value = 1; |
|---|
| 132 | + return 0; |
|---|
| 133 | + default: |
|---|
| 134 | + DRM_DEBUG("Unknown parameter %d\n", args->param); |
|---|
| 135 | + return -EINVAL; |
|---|
| 136 | + } |
|---|
| 119 | 137 | } |
|---|
| 120 | 138 | |
|---|
| 121 | 139 | static int |
|---|
| .. | .. |
|---|
| 123 | 141 | { |
|---|
| 124 | 142 | struct v3d_dev *v3d = to_v3d_dev(dev); |
|---|
| 125 | 143 | struct v3d_file_priv *v3d_priv; |
|---|
| 126 | | - struct drm_sched_rq *rq; |
|---|
| 144 | + struct drm_gpu_scheduler *sched; |
|---|
| 127 | 145 | int i; |
|---|
| 128 | 146 | |
|---|
| 129 | 147 | v3d_priv = kzalloc(sizeof(*v3d_priv), GFP_KERNEL); |
|---|
| .. | .. |
|---|
| 133 | 151 | v3d_priv->v3d = v3d; |
|---|
| 134 | 152 | |
|---|
| 135 | 153 | for (i = 0; i < V3D_MAX_QUEUES; i++) { |
|---|
| 136 | | - rq = &v3d->queue[i].sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL]; |
|---|
| 137 | | - drm_sched_entity_init(&v3d_priv->sched_entity[i], &rq, 1, NULL); |
|---|
| 154 | + sched = &v3d->queue[i].sched; |
|---|
| 155 | + drm_sched_entity_init(&v3d_priv->sched_entity[i], |
|---|
| 156 | + DRM_SCHED_PRIORITY_NORMAL, &sched, |
|---|
| 157 | + 1, NULL); |
|---|
| 138 | 158 | } |
|---|
| 139 | 159 | |
|---|
| 140 | 160 | file->driver_priv = v3d_priv; |
|---|
| .. | .. |
|---|
| 155 | 175 | kfree(v3d_priv); |
|---|
| 156 | 176 | } |
|---|
| 157 | 177 | |
|---|
| 158 | | -static const struct file_operations v3d_drm_fops = { |
|---|
| 159 | | - .owner = THIS_MODULE, |
|---|
| 160 | | - .open = drm_open, |
|---|
| 161 | | - .release = drm_release, |
|---|
| 162 | | - .unlocked_ioctl = drm_ioctl, |
|---|
| 163 | | - .mmap = v3d_mmap, |
|---|
| 164 | | - .poll = drm_poll, |
|---|
| 165 | | - .read = drm_read, |
|---|
| 166 | | - .compat_ioctl = drm_compat_ioctl, |
|---|
| 167 | | - .llseek = noop_llseek, |
|---|
| 168 | | -}; |
|---|
| 178 | +DEFINE_DRM_GEM_FOPS(v3d_drm_fops); |
|---|
| 169 | 179 | |
|---|
| 170 | 180 | /* DRM_AUTH is required on SUBMIT_CL for now, while we don't have GMP |
|---|
| 171 | 181 | * protection between clients. Note that render nodes would be be |
|---|
| 172 | 182 | * able to submit CLs that could access BOs from clients authenticated |
|---|
| 173 | | - * with the master node. |
|---|
| 183 | + * with the master node. The TFU doesn't use the GMP, so it would |
|---|
| 184 | + * need to stay DRM_AUTH until we do buffer size/offset validation. |
|---|
| 174 | 185 | */ |
|---|
| 175 | 186 | static const struct drm_ioctl_desc v3d_drm_ioctls[] = { |
|---|
| 176 | 187 | DRM_IOCTL_DEF_DRV(V3D_SUBMIT_CL, v3d_submit_cl_ioctl, DRM_RENDER_ALLOW | DRM_AUTH), |
|---|
| .. | .. |
|---|
| 179 | 190 | DRM_IOCTL_DEF_DRV(V3D_MMAP_BO, v3d_mmap_bo_ioctl, DRM_RENDER_ALLOW), |
|---|
| 180 | 191 | DRM_IOCTL_DEF_DRV(V3D_GET_PARAM, v3d_get_param_ioctl, DRM_RENDER_ALLOW), |
|---|
| 181 | 192 | DRM_IOCTL_DEF_DRV(V3D_GET_BO_OFFSET, v3d_get_bo_offset_ioctl, DRM_RENDER_ALLOW), |
|---|
| 182 | | -}; |
|---|
| 183 | | - |
|---|
| 184 | | -static const struct vm_operations_struct v3d_vm_ops = { |
|---|
| 185 | | - .fault = v3d_gem_fault, |
|---|
| 186 | | - .open = drm_gem_vm_open, |
|---|
| 187 | | - .close = drm_gem_vm_close, |
|---|
| 193 | + DRM_IOCTL_DEF_DRV(V3D_SUBMIT_TFU, v3d_submit_tfu_ioctl, DRM_RENDER_ALLOW | DRM_AUTH), |
|---|
| 194 | + DRM_IOCTL_DEF_DRV(V3D_SUBMIT_CSD, v3d_submit_csd_ioctl, DRM_RENDER_ALLOW | DRM_AUTH), |
|---|
| 188 | 195 | }; |
|---|
| 189 | 196 | |
|---|
| 190 | 197 | static struct drm_driver v3d_drm_driver = { |
|---|
| 191 | 198 | .driver_features = (DRIVER_GEM | |
|---|
| 192 | 199 | DRIVER_RENDER | |
|---|
| 193 | | - DRIVER_PRIME | |
|---|
| 194 | 200 | DRIVER_SYNCOBJ), |
|---|
| 195 | 201 | |
|---|
| 196 | 202 | .open = v3d_open, |
|---|
| .. | .. |
|---|
| 200 | 206 | .debugfs_init = v3d_debugfs_init, |
|---|
| 201 | 207 | #endif |
|---|
| 202 | 208 | |
|---|
| 203 | | - .gem_free_object_unlocked = v3d_free_object, |
|---|
| 204 | | - .gem_vm_ops = &v3d_vm_ops, |
|---|
| 205 | | - |
|---|
| 209 | + .gem_create_object = v3d_create_object, |
|---|
| 206 | 210 | .prime_handle_to_fd = drm_gem_prime_handle_to_fd, |
|---|
| 207 | 211 | .prime_fd_to_handle = drm_gem_prime_fd_to_handle, |
|---|
| 208 | | - .gem_prime_import = drm_gem_prime_import, |
|---|
| 209 | | - .gem_prime_export = drm_gem_prime_export, |
|---|
| 210 | | - .gem_prime_res_obj = v3d_prime_res_obj, |
|---|
| 211 | | - .gem_prime_get_sg_table = v3d_prime_get_sg_table, |
|---|
| 212 | 212 | .gem_prime_import_sg_table = v3d_prime_import_sg_table, |
|---|
| 213 | | - .gem_prime_mmap = v3d_prime_mmap, |
|---|
| 213 | + .gem_prime_mmap = drm_gem_prime_mmap, |
|---|
| 214 | 214 | |
|---|
| 215 | 215 | .ioctls = v3d_drm_ioctls, |
|---|
| 216 | 216 | .num_ioctls = ARRAY_SIZE(v3d_drm_ioctls), |
|---|
| .. | .. |
|---|
| 235 | 235 | map_regs(struct v3d_dev *v3d, void __iomem **regs, const char *name) |
|---|
| 236 | 236 | { |
|---|
| 237 | 237 | struct resource *res = |
|---|
| 238 | | - platform_get_resource_byname(v3d->pdev, IORESOURCE_MEM, name); |
|---|
| 238 | + platform_get_resource_byname(v3d_to_pdev(v3d), IORESOURCE_MEM, name); |
|---|
| 239 | 239 | |
|---|
| 240 | | - *regs = devm_ioremap_resource(v3d->dev, res); |
|---|
| 240 | + *regs = devm_ioremap_resource(v3d->drm.dev, res); |
|---|
| 241 | 241 | return PTR_ERR_OR_ZERO(*regs); |
|---|
| 242 | 242 | } |
|---|
| 243 | 243 | |
|---|
| .. | .. |
|---|
| 247 | 247 | struct drm_device *drm; |
|---|
| 248 | 248 | struct v3d_dev *v3d; |
|---|
| 249 | 249 | int ret; |
|---|
| 250 | + u32 mmu_debug; |
|---|
| 250 | 251 | u32 ident1; |
|---|
| 251 | 252 | |
|---|
| 252 | | - dev->coherent_dma_mask = DMA_BIT_MASK(36); |
|---|
| 253 | 253 | |
|---|
| 254 | | - v3d = kzalloc(sizeof(*v3d), GFP_KERNEL); |
|---|
| 255 | | - if (!v3d) |
|---|
| 256 | | - return -ENOMEM; |
|---|
| 257 | | - v3d->dev = dev; |
|---|
| 258 | | - v3d->pdev = pdev; |
|---|
| 254 | + v3d = devm_drm_dev_alloc(dev, &v3d_drm_driver, struct v3d_dev, drm); |
|---|
| 255 | + if (IS_ERR(v3d)) |
|---|
| 256 | + return PTR_ERR(v3d); |
|---|
| 257 | + |
|---|
| 259 | 258 | drm = &v3d->drm; |
|---|
| 260 | 259 | |
|---|
| 261 | | - ret = map_regs(v3d, &v3d->bridge_regs, "bridge"); |
|---|
| 262 | | - if (ret) |
|---|
| 263 | | - goto dev_free; |
|---|
| 260 | + platform_set_drvdata(pdev, drm); |
|---|
| 264 | 261 | |
|---|
| 265 | 262 | ret = map_regs(v3d, &v3d->hub_regs, "hub"); |
|---|
| 266 | 263 | if (ret) |
|---|
| 267 | | - goto dev_free; |
|---|
| 264 | + return ret; |
|---|
| 268 | 265 | |
|---|
| 269 | 266 | ret = map_regs(v3d, &v3d->core_regs[0], "core0"); |
|---|
| 270 | 267 | if (ret) |
|---|
| 271 | | - goto dev_free; |
|---|
| 268 | + return ret; |
|---|
| 269 | + |
|---|
| 270 | + mmu_debug = V3D_READ(V3D_MMU_DEBUG_INFO); |
|---|
| 271 | + dev->coherent_dma_mask = |
|---|
| 272 | + DMA_BIT_MASK(30 + V3D_GET_FIELD(mmu_debug, V3D_MMU_PA_WIDTH)); |
|---|
| 273 | + v3d->va_width = 30 + V3D_GET_FIELD(mmu_debug, V3D_MMU_VA_WIDTH); |
|---|
| 272 | 274 | |
|---|
| 273 | 275 | ident1 = V3D_READ(V3D_HUB_IDENT1); |
|---|
| 274 | 276 | v3d->ver = (V3D_GET_FIELD(ident1, V3D_HUB_IDENT1_TVER) * 10 + |
|---|
| .. | .. |
|---|
| 276 | 278 | v3d->cores = V3D_GET_FIELD(ident1, V3D_HUB_IDENT1_NCORES); |
|---|
| 277 | 279 | WARN_ON(v3d->cores > 1); /* multicore not yet implemented */ |
|---|
| 278 | 280 | |
|---|
| 281 | + v3d->reset = devm_reset_control_get_exclusive(dev, NULL); |
|---|
| 282 | + if (IS_ERR(v3d->reset)) { |
|---|
| 283 | + ret = PTR_ERR(v3d->reset); |
|---|
| 284 | + |
|---|
| 285 | + if (ret == -EPROBE_DEFER) |
|---|
| 286 | + return ret; |
|---|
| 287 | + |
|---|
| 288 | + v3d->reset = NULL; |
|---|
| 289 | + ret = map_regs(v3d, &v3d->bridge_regs, "bridge"); |
|---|
| 290 | + if (ret) { |
|---|
| 291 | + dev_err(dev, |
|---|
| 292 | + "Failed to get reset control or bridge regs\n"); |
|---|
| 293 | + return ret; |
|---|
| 294 | + } |
|---|
| 295 | + } |
|---|
| 296 | + |
|---|
| 279 | 297 | if (v3d->ver < 41) { |
|---|
| 280 | 298 | ret = map_regs(v3d, &v3d->gca_regs, "gca"); |
|---|
| 281 | 299 | if (ret) |
|---|
| 282 | | - goto dev_free; |
|---|
| 300 | + return ret; |
|---|
| 283 | 301 | } |
|---|
| 284 | 302 | |
|---|
| 285 | 303 | v3d->mmu_scratch = dma_alloc_wc(dev, 4096, &v3d->mmu_scratch_paddr, |
|---|
| 286 | 304 | GFP_KERNEL | __GFP_NOWARN | __GFP_ZERO); |
|---|
| 287 | 305 | if (!v3d->mmu_scratch) { |
|---|
| 288 | 306 | dev_err(dev, "Failed to allocate MMU scratch page\n"); |
|---|
| 289 | | - ret = -ENOMEM; |
|---|
| 290 | | - goto dev_free; |
|---|
| 307 | + return -ENOMEM; |
|---|
| 291 | 308 | } |
|---|
| 292 | 309 | |
|---|
| 293 | 310 | pm_runtime_use_autosuspend(dev); |
|---|
| 294 | 311 | pm_runtime_set_autosuspend_delay(dev, 50); |
|---|
| 295 | 312 | pm_runtime_enable(dev); |
|---|
| 296 | 313 | |
|---|
| 297 | | - ret = drm_dev_init(&v3d->drm, &v3d_drm_driver, dev); |
|---|
| 298 | | - if (ret) |
|---|
| 299 | | - goto dma_free; |
|---|
| 300 | | - |
|---|
| 301 | | - platform_set_drvdata(pdev, drm); |
|---|
| 302 | | - drm->dev_private = v3d; |
|---|
| 303 | | - |
|---|
| 304 | 314 | ret = v3d_gem_init(drm); |
|---|
| 305 | 315 | if (ret) |
|---|
| 306 | | - goto dev_destroy; |
|---|
| 316 | + goto dma_free; |
|---|
| 307 | 317 | |
|---|
| 308 | 318 | ret = v3d_irq_init(v3d); |
|---|
| 309 | 319 | if (ret) |
|---|
| .. | .. |
|---|
| 319 | 329 | v3d_irq_disable(v3d); |
|---|
| 320 | 330 | gem_destroy: |
|---|
| 321 | 331 | v3d_gem_destroy(drm); |
|---|
| 322 | | -dev_destroy: |
|---|
| 323 | | - drm_dev_put(drm); |
|---|
| 324 | 332 | dma_free: |
|---|
| 325 | 333 | dma_free_wc(dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr); |
|---|
| 326 | | -dev_free: |
|---|
| 327 | | - kfree(v3d); |
|---|
| 328 | 334 | return ret; |
|---|
| 329 | 335 | } |
|---|
| 330 | 336 | |
|---|
| .. | .. |
|---|
| 337 | 343 | |
|---|
| 338 | 344 | v3d_gem_destroy(drm); |
|---|
| 339 | 345 | |
|---|
| 340 | | - drm_dev_put(drm); |
|---|
| 341 | | - |
|---|
| 342 | | - dma_free_wc(v3d->dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr); |
|---|
| 346 | + dma_free_wc(v3d->drm.dev, 4096, v3d->mmu_scratch, |
|---|
| 347 | + v3d->mmu_scratch_paddr); |
|---|
| 343 | 348 | |
|---|
| 344 | 349 | return 0; |
|---|
| 345 | 350 | } |
|---|
| .. | .. |
|---|
| 353 | 358 | }, |
|---|
| 354 | 359 | }; |
|---|
| 355 | 360 | |
|---|
| 356 | | -static int __init v3d_drm_register(void) |
|---|
| 357 | | -{ |
|---|
| 358 | | - return platform_driver_register(&v3d_platform_driver); |
|---|
| 359 | | -} |
|---|
| 360 | | - |
|---|
| 361 | | -static void __exit v3d_drm_unregister(void) |
|---|
| 362 | | -{ |
|---|
| 363 | | - platform_driver_unregister(&v3d_platform_driver); |
|---|
| 364 | | -} |
|---|
| 365 | | - |
|---|
| 366 | | -module_init(v3d_drm_register); |
|---|
| 367 | | -module_exit(v3d_drm_unregister); |
|---|
| 361 | +module_platform_driver(v3d_platform_driver); |
|---|
| 368 | 362 | |
|---|
| 369 | 363 | MODULE_ALIAS("platform:v3d-drm"); |
|---|
| 370 | 364 | MODULE_DESCRIPTION("Broadcom V3D DRM Driver"); |
|---|